[PATCH] D25826: [ELF] Show error location for 'undefined symbol' errors

[Eugene Leviant via llvm-commits]

evgeny777 added inline comments.


================
Comment at: ELF/InputFiles.cpp:61
+template <class ELFT>
+bool DIHelperImpl<ELFT>::getLineInfo(InputSectionBase<ELFT> *S, uintX_t Offset,
+                                     DILineInfo &LineInfo) {
----------------
grimar wrote:
> I wonder if this class can be not templated.
> You probably can pass uint64_t Addr and DILineInfo &LineInfo only.
I was thinking about this also, but I need ObjectFile<ELFT> to construct object::ObjectFile. Also I need to know endianess and pointer size.


https://reviews.llvm.org/D25826