[PATCH] D25841: Add a space to work around a Windows CPython / MSys quoting bug

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 13:11:43 PDT 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL284768: Add a space to work around a Windows CPython / MSys quoting bug (authored by rnk).

Changed prior to commit:
  https://reviews.llvm.org/D25841?vs=75341&id=75342#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D25841

Files:
  lld/trunk/test/ELF/libsearch.s
  lld/trunk/test/ELF/version-script-err.s


Index: lld/trunk/test/ELF/version-script-err.s
===================================================================
--- lld/trunk/test/ELF/version-script-err.s
+++ lld/trunk/test/ELF/version-script-err.s
@@ -4,7 +4,7 @@
 // RUN: not ld.lld -shared %t.o -o %t.so --version-script %p/Inputs/version-script-err.script 2>&1 | FileCheck %s
 // CHECK: ; expected, but got }
 
-// RUN: echo    "\"" > %terr1.script
+// RUN: echo    " \"" > %terr1.script
 // RUN: not ld.lld --version-script %terr1.script -shared %t.o -o %t.so 2>&1 | \
 // RUN:   FileCheck -check-prefix=ERR1 %s
 // ERR1: unclosed quote
Index: lld/trunk/test/ELF/libsearch.s
===================================================================
--- lld/trunk/test/ELF/libsearch.s
+++ lld/trunk/test/ELF/libsearch.s
@@ -90,7 +90,7 @@
 // RUN: llvm-readobj --symbols %t3 | FileCheck --check-prefix=DYNAMIC %s
 
 // -nostdlib
-// RUN: echo 'SEARCH_DIR("'%t.dir'")' > %t.script
+// RUN: echo ' SEARCH_DIR("'%t.dir'")' > %t.script
 // RUN: ld.lld -o %t3 %t.o -script %t.script -lls
 // RUN: not ld.lld -o %t3 %t.o -script %t.script -lls -nostdlib \
 // RUN:   2>&1 | FileCheck --check-prefix=NOSTDLIB %s


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25841.75342.patch
Type: text/x-patch
Size: 1156 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161020/2566443a/attachment.bin>


More information about the llvm-commits mailing list