[PATCH] D25826: [ELF] Show error location for 'undefined symbol' errors

[Eugene Leviant via llvm-commits]

evgeny777 added inline comments.


================
Comment at: ELF/Error.cpp:42
+void elf::error(const Twine &Source, const Twine &Msg) {
+  *ErrorOS << Source << ": error: " << Msg << "\n";
   HasError = true;
----------------
ruiu wrote:
> I think I'm inclined to showing ARGV[0] even for undefined symbol errors to keep them consistent with other linker-issued errors. I do not see a reason to not do except for making error lines a bit shorter.
No problem, but you'll get both path to linker and path to file in a single error message. Isn't this confusing? BTW ld and gold don't show argv0 for this error type.


https://reviews.llvm.org/D25826