[PATCH] D25578: [codeview] support emitting indirect virtual base class information

[Reid Kleckner via llvm-commits]

rnk added inline comments.


================
Comment at: include/llvm/IR/DebugInfoFlags.def:44
 HANDLE_DI_FLAG((1 << 20), NoReturn)
+HANDLE_DI_FLAG((1 << 21), Indirect)
 
----------------
rnk wrote:
> @aprantl, should we sorry about running out of these bits now? We only want to use this flag with DW_TAG_inheritance types, so we could do something like reuse the `StaticMember` flag. We can still introduce a new name, and maybe make it hyper-specific, like `IndirectVirtualBase`.
> 
> This is worth thinking about since these flags go into bitcode, and we need to be backwards compatible with that once we release it.
Let's do this. We can reuse the FwdDecl flag as discussed. You can't forward declare a DW_TAG_inheritance node.


https://reviews.llvm.org/D25578