[PATCH] D25645: [ADT] Add CachedHashString.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 15:10:28 PDT 2016


mehdi_amini added a comment.

Couldn't `CachedHashString` just wrap a `CachedHashStringRef`?

Or even have a single implementation:

  template<bool Owning>
  class CachedHashStringRefBase {
    ...
  
    ~CachedHashStringRefBase() {
      if (owning) delete...
  }
  using CachedHashStringRef = CachedHashStringRefBase<false>;
  using CachedHashString = CachedHashStringRefBase<true>;




https://reviews.llvm.org/D25645





More information about the llvm-commits mailing list