[PATCH] D25790: Fix *_EXTEND_VECTOR_INREG legalization

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 13:11:26 PDT 2016


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:3366
+    }
     return DAG.getNode(N->getOpcode(), dl, NVT, Promoted);
   }
----------------
Either move the return into each case of the switch statement (to allow defaults to elegantly fall through) or provide an llvm_unreachable for default.


https://reviews.llvm.org/D25790





More information about the llvm-commits mailing list