[PATCH] D24795: [ELF] Linkerscript: Try to put section to the last PT_LOAD, in case there is no exact segment specification

[Eugene Leviant via llvm-commits]

Yeah, you're right :). See my previous message.

2016-10-19 17:39 GMT+03:00 Rafael Espíndola <rafael.espindola at gmail.com>:
>> ================
>> Comment at: ELF/LinkerScript.cpp:713
>> +
>>      if (!PhdrIds.empty()) {
>>        // Assign headers specified by linker script
>> ----------------
>> rafael wrote:
>>> This if is not necessary anymore, no?
>> Not exactly. You may have no PT_LOAD segments in PHDRS directive. GNU gold (bunutils 2.26) crashes in such case. I think we shouldn't
>
> But the if has no else and the body is just a loop that will run 0
> times is the vector is empty.
>
> Cheers,
> Rafael