[PATCH] D25645: [ADT] Add CachedHashString.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 05:26:25 PDT 2016


On 17 October 2016 at 18:25, Justin Lebar <jlebar at google.com> wrote:
> jlebar added a comment.
>
> Rafael, Tim and I were looking for a second opinion -- does this seem to you like a sane thing to do?  The immediate problem I'm trying to solve here is to convert code that's using SmallSetVector<std::string>, which doesn't work after converting SmallSetVector to use DenseSet, because you can't store an std::string in a DenseSet.

I hit that very same problem some time ago and dropped it. So yes, I
this this is sane.

Thanks for working on it.

Cheers,
Rafael


More information about the llvm-commits mailing list