[PATCH] D25691: [DAGCombiner] Add vector demanded elements support to computeKnownBits

[Simon Pilgrim via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2555
+      unsigned Idx = ConstEltNo->getZExtValue();
+      assert(Idx < NumSrcElts && "Out of range vector element index");
+      APInt DemandedElt = APInt::getOneBitSet(NumSrcElts, Idx);
----------------
efriedma wrote:
> Are your sure it isn't possible to trigger this assertion?  I think DAGCombine will delete an extractelement with an out-of-range index, but you can't depend on that happening before this code runs.
OK thanks - I misunderstood your request for a check - I'll fix it.


Repository:
  rL LLVM

https://reviews.llvm.org/D25691