[PATCH] D25730: Remove TimeValue usage from llvm/Support

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 18 11:25:49 PDT 2016


mehdi_amini added inline comments.


================
Comment at: include/llvm/Object/Archive.h:25
 #include "llvm/Support/MemoryBuffer.h"
+#include "llvm/Support/TimeValue.h"
 
----------------
It seems to indicate that there as still uses of TimeValue in here?


================
Comment at: include/llvm/Support/CachePruning.h:64
+  std::chrono::seconds Expiration{0};
+  std::chrono::seconds Interval{0};
   unsigned PercentageOfAvailableSpace = 0;
----------------
Why not `= 0` ?
(http://llvm.org/docs/CodingStandards.html#do-not-use-braced-initializer-lists-to-call-a-constructor )


https://reviews.llvm.org/D25730





More information about the llvm-commits mailing list