[PATCH] D25631: [LV] Avoid emitting trivially dead instructions

Matthew Simpson via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 18 11:15:39 PDT 2016


mssimpso added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:4243
+  for (auto &Induction : *Legal->getInductionVars()) {
+    auto *Ind = Induction.first;
+    auto *IndUpdate = cast<Instruction>(Ind->getIncomingValueForBlock(Latch));
----------------
mkuper wrote:
> Ind/Induction combined with the two "autos" is confusing. Maybe make the type of Ind explicit (or call it IndPhi?)?
I'll make the type explicit. Thanks Michael!


https://reviews.llvm.org/D25631





More information about the llvm-commits mailing list