[PATCH] D25687: [PGO] fix bogus warning for merging empty llvm profile file

Rong Xu via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 18 10:56:02 PDT 2016


empty file was already there. I'm just reusing it.

On Tue, Oct 18, 2016 at 10:36 AM, David Li <davidxl at google.com> wrote:

> davidxl added inline comments.
>
>
> ================
> Comment at: test/tools/llvm-profdata/merge_empty_profile.test:3
> +
> +RUN: llvm-profdata merge -text -o %t_clang.proftext
> %p/Inputs/empty.proftext %p/Inputs/clang_profile.proftext
> +RUN: FileCheck --input-file=%t_clang.proftext %s
> -check-prefix=CLANG_PROF_TEXT
> ----------------
> there is no need to check in an empty file. Just 'touch
> %t_empty.proftext'  or 'echo -n "" > %t_empty.proftext"
>
>
> https://reviews.llvm.org/D25687
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161018/b19f2ea3/attachment.html>


More information about the llvm-commits mailing list