[llvm] r284490 - Disable fatal errors in the Verifier instantiated by bugpoint's crash

[Adrian Prantl via llvm-commits]

Author: adrian
Date: Tue Oct 18 11:24:43 2016
New Revision: 284490

URL: http://llvm.org/viewvc/llvm-project?rev=284490&view=rev
Log:
Disable fatal errors in the Verifier instantiated by bugpoint's crash
debugger.

When bugpoint hacks at a testcase it may at one point create illegal
debug info metadata that won't even pass the Verifier. A bugpoint
*driver* built with assertions should not assert on it, but reject the
malformed intermediate step and continue to do its job.

Added:
    llvm/trunk/test/BugPoint/invalid-debuginfo.ll
Modified:
    llvm/trunk/tools/bugpoint/CrashDebugger.cpp

Added: llvm/trunk/test/BugPoint/invalid-debuginfo.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/BugPoint/invalid-debuginfo.ll?rev=284490&view=auto
==============================================================================
--- llvm/trunk/test/BugPoint/invalid-debuginfo.ll (added)
+++ llvm/trunk/test/BugPoint/invalid-debuginfo.ll Tue Oct 18 11:24:43 2016
@@ -0,0 +1,22 @@
+; RUN: bugpoint -load %llvmshlibdir/BugpointPasses%shlibext %s -output-prefix %t -bugpoint-crash-too-many-cus -silence-passes 2>&1 | FileCheck %s
+; REQUIRES: loadable_module
+; CHECK: All DICompileUnits must be listed in llvm.dbg.cu
+
+; When bugpoint hacks at this testcase it will at one point create illegal IR
+; that won't even pass the Verifier. A bugpoint *driver* built with assertions
+; should not assert on it, but reject the malformed intermediate step.
+define void @f() !dbg !9 { ret void }
+!llvm.dbg.cu = !{!0, !1, !2, !3, !4, !5}
+!0 = distinct !DICompileUnit(language: 12, file: !6)
+!1 = distinct !DICompileUnit(language: 12, file: !6)
+!2 = distinct !DICompileUnit(language: 12, file: !6)
+!3 = distinct !DICompileUnit(language: 12, file: !6)
+!4 = distinct !DICompileUnit(language: 12, file: !6)
+!5 = distinct !DICompileUnit(language: 12, file: !6)
+!6 = !DIFile(filename: "path/to/file", directory: "/path/to/dir")
+
+!llvm.module.flags = !{!7, !8}
+!7 = !{i32 2, !"Dwarf Version", i32 4}
+!8 = !{i32 2, !"Debug Info Version", i32 3}
+
+!9 = distinct !DISubprogram(unit: !0)

Modified: llvm/trunk/tools/bugpoint/CrashDebugger.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/bugpoint/CrashDebugger.cpp?rev=284490&r1=284489&r2=284490&view=diff
==============================================================================
--- llvm/trunk/tools/bugpoint/CrashDebugger.cpp (original)
+++ llvm/trunk/tools/bugpoint/CrashDebugger.cpp Tue Oct 18 11:24:43 2016
@@ -733,7 +733,7 @@ bool ReduceCrashingInstructions::TestIns
 
   // Verify that this is still valid.
   legacy::PassManager Passes;
-  Passes.add(createVerifierPass());
+  Passes.add(createVerifierPass(/*FatalErrors=*/false));
   Passes.run(*M);
 
   // Try running on the hacked up program...
@@ -809,7 +809,7 @@ bool ReduceCrashingNamedMD::TestNamedMDs
 
   // Verify that this is still valid.
   legacy::PassManager Passes;
-  Passes.add(createVerifierPass());
+  Passes.add(createVerifierPass(/*FatalErrors=*/false));
   Passes.run(*M);
 
   // Try running on the hacked up program...
@@ -876,7 +876,7 @@ bool ReduceCrashingNamedMDOps::TestNamed
 
   // Verify that this is still valid.
   legacy::PassManager Passes;
-  Passes.add(createVerifierPass());
+  Passes.add(createVerifierPass(/*FatalErrors=*/false));
   Passes.run(*M);
 
   // Try running on the hacked up program...