[PATCH] D25440: [Target] remove TargetRecip class; move reciprocal estimate isel functionality to TargetLowering

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 18 09:04:50 PDT 2016


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D25440#573003, @spatel wrote:

> Patch updated:
>  Implement Hal's suggestion to reduce the repeated code by pulling getRsqrtEstimate/getSqrtRefinementSteps and the Div siblings into DAGCombiner. This changes the hook interface, so the patch grows a bit, but this is less ugly overall. :)


Thanks, this LGTM.


https://reviews.llvm.org/D25440





More information about the llvm-commits mailing list