[PATCH] D25620: DebugInfo: use uint32_t instead of uint64_t for alignment

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 14:10:30 PDT 2016


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Small nitpicks inline, but otherwise this looks good to me!



================
Comment at: lib/IR/LLVMContextImpl.h:352
   uint64_t SizeInBits;
-  uint64_t AlignInBits;
+  uint32_t AlignInBits;
   uint64_t OffsetInBits;
----------------
Here we could reorder the fields so AlignInBits isn't stuck between two 64-bit values.


================
Comment at: lib/IR/LLVMContextImpl.h:433
   uint64_t SizeInBits;
-  uint64_t AlignInBits;
+  uint32_t AlignInBits;
   uint64_t OffsetInBits;
----------------
Same here.


https://reviews.llvm.org/D25620





More information about the llvm-commits mailing list