[PATCH] D25693: [AMDGPU] Emit constant address space data in .rodata section and use relocations instead of fixups (amdhsa only)

[Konstantin Zhuravlyov via llvm-commits]

kzhuravl added inline comments.


================
Comment at: lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:59
+/// target triple \p TT, false otherwise.
+bool emitConstantsToTextSection(const Triple &TT);
+
----------------
tony-tye wrote:
> Would it be better to name this isEmitConstantsToTextSection or shouldEmitConstantsToTextSection since it does not actually do the emitting?
Yes, `shouldEmitConstantsToTextSection` sounds a lot better and in the same naming spirit as `shouldEmitFixup`, `shouldEmitGOTReloc`, etc. Thanks.


https://reviews.llvm.org/D25693