[PATCH] D25687: [PGO] fix bogus warning for merging empty llvm profile file

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 12:54:01 PDT 2016


vsk added inline comments.


================
Comment at: tools/llvm-profdata/llvm-profdata.cpp:159
   for (auto &I : *Reader) {
+    const StringRef FuncName = I.Name;
     if (Error E = WC->Writer.addRecord(std::move(I), Input.Weight)) {
----------------
xur wrote:
> davidxl wrote:
> > unrelated change?
> this is for the use-after-move fix I mentioned in the description. 
> You want to split to another patch?
I think it'd be better to land this change separately.


https://reviews.llvm.org/D25687





More information about the llvm-commits mailing list