[lld] r284407 - ELF: Implement skip() as (void)next()

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 11:55:55 PDT 2016


Thanks!

On 17 October 2016 at 14:40, Justin Bogner via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: bogner
> Date: Mon Oct 17 13:40:35 2016
> New Revision: 284407
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284407&view=rev
> Log:
> ELF: Implement skip() as (void)next()
>
> Thanks to Rafael for pointing out the simplification.
>
> Modified:
>     lld/trunk/ELF/ScriptParser.cpp
>
> Modified: lld/trunk/ELF/ScriptParser.cpp
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/ScriptParser.cpp?rev=284407&r1=284406&r2=284407&view=diff
> ==============================================================================
> --- lld/trunk/ELF/ScriptParser.cpp (original)
> +++ lld/trunk/ELF/ScriptParser.cpp Mon Oct 17 13:40:35 2016
> @@ -150,15 +150,7 @@ bool ScriptParserBase::consume(StringRef
>    return true;
>  }
>
> -void ScriptParserBase::skip() {
> -  if (Error)
> -    return;
> -  if (atEOF()) {
> -    setError("unexpected EOF");
> -    return;
> -  }
> -  ++Pos;
> -}
> +void ScriptParserBase::skip() { (void)next(); }
>
>  void ScriptParserBase::expect(StringRef Expect) {
>    if (Error)
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list