[PATCH] D25477: [JumpThreading] Unfold selects that depend on the same condition

[James Molloy via llvm-commits]

jmolloy added reviewers: mcrosier, gberry, sebpop.
jmolloy added a comment.

Hi Pablo,

I only have a couple of trivial comments, but I'm not able to approve this patch myself as I wrote part of it and because I'm not well enough versed in this pass to give the LGTM.

Adding another set of reviewers who hopefully will be able to.

James



================
Comment at: include/llvm/Transforms/Scalar/JumpThreading.h:139
   bool doesBlockHaveProfileData(BasicBlock *BB);
+  SelectInst* GetSelectFedByPhi(PHINode *PN);
+  void ExpandSelect(SelectInst *SI);
----------------
functions should start with a lowercase letter.


================
Comment at: lib/Transforms/Scalar/JumpThreading.cpp:2048
+      else
+        changed = true;
 
----------------
Variables should start with an Uppercase letter.


https://reviews.llvm.org/D25477