[PATCH] D25090: [Object/ELF] - Check that e_shnum is null when e_shoff is.
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 17 04:26:02 PDT 2016
grimar added a comment.
In https://reviews.llvm.org/D25090#571020, @rafael wrote:
> LGTM, but please also include a lld test as we might want to me a bit more lenient in here in the future.
r284375
Also I had to modify 2 precompiled inputs to commit this finally. Because it broke buildbots:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/21736/steps/test/logs/stdio
So I just zeroed the e_shnum fields in hex editor to let them pass this new check (https://reviews.llvm.org/rL284374).
Repository:
rL LLVM
https://reviews.llvm.org/D25090
More information about the llvm-commits
mailing list