[PATCH] D25667: Fix call sites with spurious .c_str() calls from explicit StringRef conversion (NFC)

[Malcolm Parsons via llvm-commits]

malcolm.parsons added inline comments.


================
Comment at: clang/lib/Driver/Job.cpp:183
         StringRef ShortName = llvm::sys::path::filename(CrashInfo->Filename);
-        printArg(OS, llvm::StringRef(ShortName.str().c_str()), Quote);
+        printArg(OS, ShortName.str(), Quote);
         continue;
----------------
.str() looks redundant.


================
Comment at: clang/lib/Driver/Job.cpp:196
     OS << ' ';
-    printArg(OS, llvm::StringRef(CrashInfo->VFSPath.str().c_str()), Quote);
+    printArg(OS, CrashInfo->VFSPath.str(), Quote);
 
----------------
.str() looks redundant.


================
Comment at: lldb/source/Interpreter/OptionValueArray.cpp:75
                                            VarSetOperationType op) {
-  Args args(llvm::StringRef(value.str().c_str()));
+  Args args(value.str());
   Error error = SetArgs(args, op);
----------------
.str() looks redundant.


================
Comment at: lldb/source/Interpreter/OptionValueDictionary.cpp:201
                                                 VarSetOperationType op) {
-  Args args(llvm::StringRef(value.str().c_str()));
+  Args args(value.str());
   Error error = SetArgs(args, op);
----------------
.str() looks redundant.


================
Comment at: lldb/source/Interpreter/OptionValueFileSpec.cpp:83
       m_value_was_set = true;
-      m_current_value.SetFile(llvm::StringRef(value.str().c_str()), m_resolve);
+      m_current_value.SetFile(value.str(), m_resolve);
       m_data_sp.reset();
----------------
.str() looks redundant.


================
Comment at: lldb/source/Interpreter/OptionValueFileSpecLIst.cpp:44
   Error error;
-  Args args(llvm::StringRef(value.str().c_str()));
+  Args args(value.str());
   const size_t argc = args.GetArgumentCount();
----------------
.str() looks redundant.


================
Comment at: lldb/source/Interpreter/OptionValuePathMappings.cpp:46
   Error error;
-  Args args(llvm::StringRef(value.str().c_str()));
+  Args args(value.str());
   const size_t argc = args.GetArgumentCount();
----------------
.str() looks redundant.


================
Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1024
 
-  return llvm::StringSwitch<uint32_t>(llvm::StringRef(mode.str().c_str()))
+  return llvm::StringSwitch<uint32_t>(mode.str())
       .Case("r", File::eOpenOptionRead)
----------------
.str() looks redundant.


================
Comment at: llvm/lib/MC/ELFObjectWriter.cpp:869
         Buf += Name.substr(Pos + Skip);
-        Name = StringRef(VersionSymSaver.save(StringRef(Buf.c_str())));
+        Name = VersionSymSaver.save(StringRef(Buf));
       }
----------------
sed didn't do what you wanted here.


https://reviews.llvm.org/D25667