[PATCH] D25639: Add ctor for string literal to StringRef, and make explicit the conversion from const char *

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 16 20:49:42 PDT 2016


I’ll try with a “sed” line and see how it goes!

> On Oct 16, 2016, at 8:48 PM, Zachary Turner <zturner at google.com> wrote:
> 
> FWIW it might not even make a difference in practice,, just a thought I had.  If it's not easy to figure out then don't worry about it.  (I don't know anything about writing clang-tidy checks either)
> 
> On Sun, Oct 16, 2016 at 8:44 PM Mehdi AMINI <mehdi.amini at apple.com <mailto:mehdi.amini at apple.com>> wrote:
> mehdi_amini added a comment.
> 
> "Maybe"?
> (I've never wrote anything with clang-tidy before, so I'm not sure I could do it by myself right now)
> 
> 
> https://reviews.llvm.org/D25639 <https://reviews.llvm.org/D25639>
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161016/efdc0a45/attachment.html>


More information about the llvm-commits mailing list