[PATCH] D23366: [AArch64] Assign stack locations to increase load/store pairing.

[James Molloy via llvm-commits]

jmolloy added a comment.

This generally looks good to me, although I haven't had a super in depth look. Given the code complexity it'd be nice to have more than 2 testcases though.

James



================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:1230
+  // Weighted non-directed graph of stack slot pair affinities.  Weights
+  // indicate how frequently the pair of stack slots are referrenced in the same
+  // block region.
----------------
referenced*


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:1237
+  // region.
+  constexpr unsigned NumPairableRegClasses = 5;
+  SmallVector<int, 16> BlockRefs[2][NumPairableRegClasses];
----------------
Can't this just be "const"?


https://reviews.llvm.org/D23366