[PATCH] D25346: [test-suite] [Polybench] run tests twice with -ffp-contract=on/off

[Renato Golin via llvm-commits]

rengolin requested changes to this revision.
rengolin added a comment.
This revision now requires changes to proceed.

Why are you setting the tolerance AND disabling FP contract, which I think we agreed it wasn't the right way?

Also, the attribute optnone will make sure none of the https://reviews.llvm.org/owners/package/2/, O3 passes will make any difference, and will confuse the hell out of people trying to benchmark those tests.

You're adding the pragma to the strict loop AND the non-strict loop, what's the point? If both have contract disable, than obviously the compare will always work, regardless of the compiler flags the user sets.

>From what I can see you've done everything we agreed should not be done, so I'm not sure what this patch is about...

cheers,
--renato


https://reviews.llvm.org/D25346