zvi added inline comments. ================ Comment at: test/CodeGen/X86/negate-i1.ll:131 ; X32-NEXT: movl %eax, %edx +; X32-NEXT: sarl $31, %edx ; X32-NEXT: retl ---------------- This SAR is redundant. Does DAGCombine know that SAR(all_ones/allzeros) is redundant? https://reviews.llvm.org/D25485