yuyichao added a comment. Ping. Does this still need more review or is this OK to merge? I'll also need someone else to push for me since I don't have commit access. https://reviews.llvm.org/D25069