[PATCH] D25588: Statistic/Timer: Include timers in PrintStatisticsJSON().

Bruno Cardoso Lopes via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 19:07:27 PDT 2016


bruno added a comment.

This is very nice. A couple of questions/comments:

- Looks like if you pass `-stats -stats-json -time-passes` then all timers and statistics are printed together, what happens if you just pass `-stats-json -time-passes`, would that only output the timers in json format? Also, when printed together, are they part of the same "group"? it's not clear from the tests how the output layout works.
- Do you plan to somehow track different runs of the same pass? Right now that could be inferred  by looking into the output order, but it would be nice (not necessarily in this patch) to easily access that information; I remember it to be really useful when comparing compile time between two different compilers, I could then notice when one compiler run the same pass more times than the other and it would also help identify when specific runs were slower due to the influence of other opts.


Repository:
  rL LLVM

https://reviews.llvm.org/D25588





More information about the llvm-commits mailing list