[PATCH] D25484: Post commit review of changes to D18226

[David Li via llvm-commits]

davidxl added inline comments.


================
Comment at: test/CodeGen/AArch64/tail-dup-repeat-worklist.ll:37
+while.cond.outer:                                 ; preds = %dup1, %entry
+  %progress.0.ph = phi i32 [ 0, %entry ], [ %progress.1, %dup1 ]
+  %inc77 = add nsw i32 %progress.0.ph, 1
----------------
can you clean up the test case a little more?
1) simplify variable names
2) remove unecessary types
3) simplify block bodies to remove unessential things.


================
Comment at: test/CodeGen/X86/tail-dup-merge-loop-headers.ll:6
+; Function Attrs: nounwind uwtable
+; CHECK-LABEL: tail_dup_merge_loops
+; CHECK: # %entry
----------------
Same here -- please reduce the test case further to minimal form.


Repository:
  rL LLVM

https://reviews.llvm.org/D25484