[PATCH] D25611: When moving a zext near to its associated load, do not retain the origial debug location.

[Andrea Di Biagio via llvm-commits]

andreadb added a comment.

Hi Adrian,
Thanks for the review.

In https://reviews.llvm.org/D25611#570679, @aprantl wrote:

> Ok. I'm fine with doing this as long as we document clearly why we are doing it, so we can remove safely remove it later should it become unnecessary. (see inline comment)


I'd like to point out that CodeGenPrepare does not check if the zext would be speculatively executed when moved to the same basic block as the load. So, preserving its location would pessimize the debugging experience, other than negatively impacting the quality of sample pgo.

I can definitely add that explanation as a comment in the code if you like.

Thanks!


https://reviews.llvm.org/D25611