[PATCH] D25616: [llvm-readobj] - Teach readobj to print PT_OPENBSD_RANDOMIZE/PT_OPENBSD_WXNEEDED headers.

[Davide Italiano via llvm-commits]

davide added inline comments.


================
Comment at: test/tools/llvm-readobj/program-headers.test:9
 RUN:     | FileCheck %s -check-prefix ELF-MIPS64
+RUN: llvm-readobj -program-headers %p/../../Object/Inputs/openbsd-phdrs.elf-x86-64 \
+RUN:     | FileCheck %s -check-prefix OPENBSD-X86-64
----------------
You should add a comment explaining how you're generating this code, so that if we need to regenerate in the future we don't have to randomly guess.


================
Comment at: test/tools/llvm-readobj/program-headers.test:154
+OPENBSD-X86-64-NEXT:     MemSize: 8
+OPENBSD-X86-64-NEXT:     Flags [ (0x4)
+OPENBSD-X86-64-NEXT:       PF_R (0x4)
----------------
Remove the `(0x4)`, here and in other parts of the patch.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:1157-1160
+
+  LLVM_READOBJ_ENUM_CASE(ELF, PT_OPENBSD_RANDOMIZE);
+  LLVM_READOBJ_ENUM_CASE(ELF, PT_OPENBSD_WXNEEDED);
+
----------------
emaste wrote:
> The grouping seems a bit odd in this switch?
Agree.


https://reviews.llvm.org/D25616