[PATCH] D23614: [PPC] Generate positive FP zero using xor insn instead of loading from constant area

Ehsan Amiri via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 09:35:37 PDT 2016


amehsan added inline comments.


================
Comment at: test/CodeGen/PowerPC/fast-isel-fcmp-nan.ll:5
 ; CHECK-LABEL: TestULT:
-; CHECK: mcrf
+; CHECK: xscmpudp
 ; CHECK: blr
----------------
kbarton wrote:
> Any insight from git blame?
Yes. It turns out that with this patch a downstream codegen bug is exposed. I have opened a [[ https://llvm.org/bugs/show_bug.cgi?id=30701 | PR for this ]]

Since fixing that bug will impact the code generated for this testcase, I prefer to leave this test unchanged. I have [[ https://llvm.org/bugs/show_bug.cgi?id=30701#c2 | explicitly mentioned in the 2nd comment of the PR ]] that a fix for that bug, should make sure we generate good code for this testcases.


https://reviews.llvm.org/D23614





More information about the llvm-commits mailing list