[PATCH] D25318: [DAG] Don't increase SDNodeOrder for dbg.value/declare.

Mikael Holmén via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 07:15:59 PDT 2016


uabelho added a comment.

In https://reviews.llvm.org/D25318#570397, @probinson wrote:

> Could you provide a small C/C++ source that demonstrates the problem using an in-tree target?  That is, something where the generated code is different with and without -g, but applying your patch makes the difference go away.  It is disappointing but not really surprising that no existing tests are affected.


I can try, but to be honest I think it's demonstrated by the two functions in the ll-file already.
By only adding a dbg.value the resulting code gets different and the difference goes away when applying the patch.

Ideally the whole output of the two functions should be compared though and not just the first pushq.


https://reviews.llvm.org/D25318





More information about the llvm-commits mailing list