[PATCH] D25585: Add interface for querying physical hardware concurrency

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.


================
Comment at: include/llvm/Support/Threading.h:121
+  /// host system, otherwise falls back to thread::hardware_concurrency().
+  unsigned hardware_physical_concurrency();
 }
----------------
mehdi_amini wrote:
> I think we may want to name it `hardware_coarse_concurrency`. Because:
> 
> - This looks like expressing better what we're looking after.
> - Hyperthreading is in some sense "physical concurrency", but sharing some resources. 
> - Other platforms may have something in between.
> 
I thought about that name after you mentioned it on the prior review thread. But I felt that saying "physical concurrency" is a better expression for what it is actually trying to give you.  I think of the hyperthreading concurrency as "logical concurrency", vs physical concurrency due to physical cores.


https://reviews.llvm.org/D25585