[PATCH] D25578: [codeview] support emitting indirect virtual base class information

[Zachary Turner via llvm-commits]

zturner added inline comments.


================
Comment at: include/llvm/DebugInfo/CodeView/TypeRecord.h:1197
   explicit VirtualBaseClassRecord(TypeRecordKind Kind) : TypeRecord(Kind) {}
   VirtualBaseClassRecord(MemberAccess Access, TypeIndex BaseType,
                          TypeIndex VBPtrType, uint64_t Offset, uint64_t Index)
----------------
rnk wrote:
> Can you remove this ctor? We appear to use the wrong kind in VirtualBaseClassRecord::deserialize.
Remove which constructor?  `deserialize` still needs to call this constructor right?


================
Comment at: test/DebugInfo/COFF/inheritance.ll:33
+; CHECK-NEXT:       AccessSpecifier: Public (0x3)
+; CHECK-NEXT:       BaseType: A ({{.*}})
+; CHECK-NEXT:       VBPtrType: const int* ({{.*}})
----------------
What does the `{{.*}}` syntax mean here?


https://reviews.llvm.org/D25578