[PATCH] D25555: [ELF] - Do not crash when object has multiple SHT_MIPS_OPTIONS

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 10:50:29 PDT 2016


ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: ELF/InputFiles.cpp:328
+    if (MipsOptions)
+      fatal("Multiple SHT_MIPS_OPTIONS sections are not allowed");
     MipsOptions.reset(new MipsOptionsInputSection<ELFT>(this, &Sec, Name));
----------------
Please include the filename. Error messages need to start with lowercase letters.


https://reviews.llvm.org/D25555





More information about the llvm-commits mailing list