[PATCH] D25564: Add interface to compute number of physical cores on host system

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 10:24:43 PDT 2016


mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: unittests/Support/Host.cpp:29
+    if (is_contained(SupportedArchs, Host.getArch()))
+      return true;
+
----------------
tejohnson wrote:
> mehdi_amini wrote:
> > May want to check tuple `<OS, arch>`, but that can be changed when it'll be needed.
> Good idea - done. This also made me realize it should be an AND condition not an OR!
Yes that's what I had in mind :)



https://reviews.llvm.org/D25564





More information about the llvm-commits mailing list