[PATCH] D25485: [x86] use 'neg' for negation of bool

[Sanjay Patel via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D25485#569279, @sdardis wrote:

> We don't have a negate instruction, we use "nor $dst, $src, $zero"  instead. "nor" present in all our ISAs except mips16 which has an actual negate instruction.
>
> Did that regression hit general MIPS code or just microMIPS? It's possible that we have a missing pattern for microMIPS in that case. I'll give this patch a whirl.


I only saw the regression for a RUN with the micromips attribute specified. Here are the tests that were affected by the LegalizeDAG patch which I'll attach here if you'd like to try it:

  LLVM :: CodeGen/Mips/llvm-ir/add.ll
   LLVM :: CodeGen/Mips/llvm-ir/mul.ll
   LLVM :: CodeGen/Mips/llvm-ir/sdiv.ll
   LLVM :: CodeGen/Mips/llvm-ir/srem.ll
   LLVM :: CodeGen/Mips/llvm-ir/sub.ll
   LLVM :: CodeGen/Mips/llvm-ir/urem.ll
   LLVM :: CodeGen/Mips/select.ll
   LLVM :: CodeGen/SystemZ/branch-07.ll
   LLVM :: CodeGen/SystemZ/risbg-01.ll
   LLVM :: CodeGen/SystemZ/shift-10.ll
   LLVM :: CodeGen/X86/negate-i1.ll


https://reviews.llvm.org/D25485