[PATCH] D21987: [XRay] Implement `llvm-xray extract`, start of the llvm-xray tool

Dean Michael Berris via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 00:32:38 PDT 2016


dberris added a comment.

I haven't added the tests, will do so when the style questions have been resolved.



================
Comment at: tools/llvm-xray/xray-extract.cc:130-132
+    return make_error<BinaryInstrELFError>(
+        "File format not supported (only does ELF).",
+        std::make_error_code(std::errc::not_supported));
----------------
dblaikie wrote:
> Test case for this codepath? (goes for all the error paths, ideally)
I'll add more test cases in the next revision.


https://reviews.llvm.org/D21987





More information about the llvm-commits mailing list