[PATCH] D24548: Add AArch64 unit tests

[Matthias Braun via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D24548#568011, @rovka wrote:

> In https://reviews.llvm.org/D24548#567443, @MatzeB wrote:
>
> > In general though these programmatic unit tests are harder to understand and more work to maintain than (well done) tests using one of the llvm tool. Of course to do this effectively we need a means to print/test the information/functionality we are interested in and right now there is no way to print the computed size next to each instruction or similar.
>
>
> Would it be ok to add a pass that annotates the MIR with the instruction sizes (as comments) just so we can have the usual kind of tests with FileCheck? Just wondering, I'm definitely leaving that for the next person that has to deal with an instruction-size related bug :)


Yes I would imagine something in the line of adding a cl::opt flag (restricted to assert builds) that either annotates .mir output or assembly output with comments, or create a new pass that prints the debug information you need (though for this specific case a whole new pass seems a bit much).


Repository:
  rL LLVM

https://reviews.llvm.org/D24548