[PATCH] D25529: LTO: Use the correct mangler function in LTOCodeGenerator::applyScopeRestrictions().

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 12:44:28 PDT 2016


mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks!



================
Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:425
     MangledName.reserve(GV.getName().size() + 1);
-    Mangler::getNameWithPrefix(MangledName, GV.getName(),
-                               MergedModule->getDataLayout());
+    Mang.getNameWithPrefix(MangledName, &GV, false);
     return MustPreserveSymbols.count(MangledName);
----------------
Can you add the comment for the bool: `Mang.getNameWithPrefix(MangledName, &GV, /* CannotUsePrivateLabel */ false)` ?




https://reviews.llvm.org/D25529





More information about the llvm-commits mailing list