[PATCH] D25495: [ThinLTO] Avoid archive member collisions

[Peter Collingbourne via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D25495#568532, @davide wrote:

> In https://reviews.llvm.org/D25495#568522, @pcc wrote:
>
> > In https://reviews.llvm.org/D25495#568493, @ruiu wrote:
> >
> > > I'm wondering if InputFile::getName() should return a unique name, such as "some/path/foobar.a:123:x.o" where 123 is an offset in the archive.
> >
> >
> > That might be something we could do in `lld::elf::getFilename()`. It could be confusing in the normal case, so maybe we could do it only if the archive contains duplicate names?
>
>
> Maybe, but I still think the change belongs to a different patch


Agreed. Rui, what do you think?

This LGTM as far as I'm concerned though.


https://reviews.llvm.org/D25495