[PATCH] D25381: [AMDGPU] Add amdgpu-unify-metadata pass

[Tom Stellard via llvm-commits]

tstellarAMD added a comment.

In https://reviews.llvm.org/D25381#568446, @rampitec wrote:

> In https://reviews.llvm.org/D25381#567873, @arsenm wrote:
>
> > This should be handled by the generic linker, this isn't an AMDGPU specific issue. I had this https://reviews.llvm.org/D20582 (but there are more comments not visible in phabricator). An RFC should be posted for whether all named metadata should behave like a set
>
>
> I see. https://reviews.llvm.org/D20582 only covers llvm.ident. The same happens to opencl.ocl.version, spir.version and others. Notably opencl and spir version handling are specific to the target stack. Like in our case we cannot use maximum version, but have to take version from the kernel module. Some other implementation probably would want different behavior. So in my opinion https://reviews.llvm.org/D20582 is a good move, but does not replace this change.


Take a look at the proposed solution here: https://marc.info/?l=llvm-commits&m=147370670326170&w=2  This is what Matt was referring to when he mentioned doing and RFC on the list.


Repository:
  rL LLVM

https://reviews.llvm.org/D25381