[PATCH] D25526: AMDGPU/SI: Handle s_getreg hazard in GCNHazardRecognizer

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 11:33:50 PDT 2016


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/AMDGPU/GCNHazardRecognizer.cpp:320
+    const MachineInstr *MI = *I;
+    if (!MI || !isSSetReg(MI->getOpcode()) || HWReg != getHWReg(TII, *MI))
+      continue;
----------------
HWReg != getHWReg looks confusing to me. getHWReg(TII, *MI) != GetRegHWReg?


https://reviews.llvm.org/D25526





More information about the llvm-commits mailing list