[PATCH] D23986: [XRay] Detect and emit sleds for sibling/tail calls

Serge Rogatch via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 11:08:26 PDT 2016


rSerge added inline comments.


================
Comment at: llvm/trunk/test/CodeGen/X86/xray-tail-call-sled.ll:12
+; CHECK-LABEL: Lxray_sled_1:
+; CHECK-NEXT:  retq
+; CHECK-NEXT:  nopw %cs:512(%rax,%rax)
----------------
Isn't it missing setting EAX to 0? The function in the disassembly seems to just `return;`, rather than `return 0;` as, I guess, `ret i32 0` requires.


Repository:
  rL LLVM

https://reviews.llvm.org/D23986





More information about the llvm-commits mailing list