[PATCH] D25495: [ThinLTO] Avoid archive member collisions

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 10:58:46 PDT 2016


ruiu added inline comments.


================
Comment at: ELF/InputFiles.cpp:726-727
+  Obj = check(lto::InputFile::create(MemoryBufferRef(
+      MB.getBuffer(), Saver.save(ArchiveName + MB.getBufferIdentifier() +
+                                 utostr(OffsetInArchive)))));
   DenseSet<const Comdat *> KeptComdats;
----------------
Can you use the object address as a unique identifier instead? I mean `utostr((uint64_t)&MB)` is always unique.


https://reviews.llvm.org/D25495





More information about the llvm-commits mailing list