[PATCH] D24956: [SelectionDAG] Add expansion and promotion of [US]MUL_LOHI
Simon Pilgrim via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 12 08:59:55 PDT 2016
RKSimon added inline comments.
================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:3035
+ !OnlyLegalOrCustom || isOperationLegalOrCustom(ISD::UMUL_LOHI, HalfVT);
+ unsigned OuterBitSize = VT.getSizeInBits();
+ unsigned InnerBitSize = HalfVT.getSizeInBits();
----------------
If this is going to start being used by vectors, shouldn't these getSizeInBits() calls be replaced with getScalarSizeInBits()?
https://reviews.llvm.org/D24956
More information about the llvm-commits
mailing list