[PATCH] D24989: Use profile info to set function section prefix to group hot/cold functions.

[Dehao Chen via llvm-commits]

danielcdh added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:216
+                         "Optimize for code generation", false, false)
+INITIALIZE_PASS_DEPENDENCY(ProfileSummaryInfoWrapperPass)
+INITIALIZE_TM_PASS_END(CodeGenPrepare, "codegenprepare",
----------------
eraman wrote:
> This is not part of your change, but why are the other analysis passes (LoopInfoWrapper etc) already specified in INITIALIZE_PASS_DEPENDENCY? 
In theory, all analysis pass it depends on should be declared here. But other analysis pass it depends on have all been declared as dependency of something initialized by LLVMInitializeXXXXXXTarget, but ProfileSummaryInfo is not such case, thus needs to be explicitly declared here.


https://reviews.llvm.org/D24989