[PATCH] D24840: Search for all predecessors of loop header while getting loop metadata

Aditya Kumar via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 08:08:54 PDT 2016


hiraditya added inline comments.


================
Comment at: llvm/lib/Analysis/LoopInfo.cpp:253
+    TI->setMetadata(LLVMContext::MD_loop, LoopID);
+    assert(!MDSet && "Multiple branches to loop header from within loop.");
+    MDSet = true;
----------------
mzolotukhin wrote:
> Are you sure that we cannot have multiple branches? I think it's true for well-formed loops, but might be incorrect in a general case.
I'll remove this assert. THanks,


https://reviews.llvm.org/D24840





More information about the llvm-commits mailing list