[PATCH] D25502: [SimplifyCFG] Don't create PHI nodes for constant bundle operands

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 00:50:11 PDT 2016


jmolloy accepted this revision.
jmolloy added a comment.
This revision is now accepted and ready to land.

LGTM, with the extra comment added.



================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:1368
+
+    if (ImmutableCallSite(I).isBundleOperand(OpIdx))
+      return false;
----------------
Could you please add a comment here as to why - something like what you wrote in your phab commit message. Just so we know that it's deliberate and not a workaround for something else.


https://reviews.llvm.org/D25502





More information about the llvm-commits mailing list