[PATCH] D23252: [ADT] Zip range adapter

bryant via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 23:01:38 PDT 2016


bryant added a comment.

The two main problems are that:

1. `apply_tuple` is defined at the bottom of the file which necessitates some very large forward decls.
2. I don't know of a direct way to invoke apply on a ctor without a wrapper func.

If the entire patch were moved to the bottom, then the clunky decls could be left out. However, zip would be separated from the rest of the iterator adapter definitions. Do you think this is a worthwhile adjustment?


Repository:
  rL LLVM

https://reviews.llvm.org/D23252





More information about the llvm-commits mailing list